Conversation
bloodyyugo
approved these changes
Sep 5, 2025
mgignac
approved these changes
Sep 5, 2025
EBerzin
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some differences in the track and cluster time distributions between data and MC that needed to be addressed.
The
simHitTimeOffsetintroduced inSvtDigitizationWithPulserDataMergingReadoutDrivershifts the time of the simulated signal (tritrig, wab) hits with respect to the pulser hits. This is needed to mimic the turn-off of the track time distribution in data. This value can be set in the readout steering file and should be around -10ns.The
additionalShiftintroduced inEcalTimeCorrectionDriverglobally moves the ECAL cluster time. This is needed to put the time peak in MC at the same time as in data to avoid cutoffs introduced at other points in the pipeline. Without the shift, the cluster time in MC peaks at 24ns, in data at 37.3. So the shift should be 13.3ns.Note: I have tried shifting both cluster time peaks to 0ns, however this breaks things since there is a hard cut at 0ns that is implemented somewhere else. Matching data and MC appears to be the safer approach.
I have also changed the
tsCorrectionScalevalue in theRawTrackerHitFitterDriversetting to the value needed to match MC to data. This correction scale globally shifts the hit time of pulser and simulated hits in the pulser overlayed-MC sample.